feat: Review UI of Navigation drawer - MEED-6831 - Meeds-io/MIPs#137 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boubaker
reviewed
Jun 18, 2024
| @@ -1,6 +1,6 @@ | |||
| siteNavigation.button.tooltip.label=Navigation du site | |||
| siteNavigation.drawer.title=Navigation du site | |||
| siteNavigation.label.btn.createNode=Cr\u00e9er un noeud | |||
| siteNavigation.label.btn.createNode=Ajouter un item | |||
There was a problem hiding this comment.
Should be managed by PO on crowdin even if it's possible to do with code
Suggested change
| siteNavigation.label.btn.createNode=Ajouter un item | |
| siteNavigation.label.btn.createNode=Cr\u00e9er un noeud |
There was a problem hiding this comment.
removed!
cc @srenault-meeds FYI
| @@ -1,6 +1,6 @@ | |||
| siteNavigation.button.tooltip.label=Site navigation | |||
| siteNavigation.drawer.title=Site navigation | |||
| siteNavigation.label.btn.createNode=Create a node | |||
| siteNavigation.label.btn.createNode=Add Item | |||
There was a problem hiding this comment.
Should be managed by PO on crowdin even if it's possible to do with code
Suggested change
| siteNavigation.label.btn.createNode=Add Item | |
| siteNavigation.label.btn.createNode=Create a node |
There was a problem hiding this comment.
removed!
cc @srenault-meeds FYI
boubaker
approved these changes
Jun 18, 2024
exo-swf
pushed a commit
that referenced
this pull request
Jun 19, 2024
…125) This PR adds UI/Ux adjustment to the site navigation drawer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UI/Ux adjustment to the site navigation drawer